datahub-project / datahub

The Metadata Platform for your Data and AI Stack
https://datahubproject.io
Apache License 2.0
9.93k stars 2.94k forks source link

feat(ingestion/openapi) enhance url config parameters #11802

Open ErenDursun opened 2 weeks ago

ErenDursun commented 2 weeks ago

// duplicates feature request

Is your feature request related to a problem? Please describe.

Some of the configuration parameters seem unnecessarily restrictive.

Describe the solution you'd like

Could we interpret the parameters swagger_file and get_token/url_complement as full URLs instead and not prefix them with url? This would be a breaking change.

Describe alternatives you've considered

Alternatively there could be an additional logic that checks if the parameters are relative paths and only then prefixes them with the url parameter. This would be backwards compatible.

Additional context

docs

url - Endpoint URL. e.g. https://example.com
swagger_file - Route for access to the swagger file. e.g. openapi.json
get_token/url_complement - Retrieving a token from the endpoint.