datahub-project / datahub

The Metadata Platform for your Data and AI Stack
https://datahubproject.io
Apache License 2.0
9.93k stars 2.94k forks source link

Glue ingested tables in lineage view shows fullname with arn #6182

Open KulykDmytro opened 2 years ago

KulykDmytro commented 2 years ago

Describe the bug Glue ingested tables in lineage view shows fullname with arn instead of {database_name}.{table_name} when Show Full Titles enabled

To Reproduce Steps to reproduce the behavior:

  1. Ingest Glue table(s)
  2. open it in Lineage graph
  3. switch on Show Full Titles

Expected behavior Full name og Glue table should be like {database_name}.{table_name}

Screenshots image image

github-actions[bot] commented 2 years ago

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

aditya-radhakrishnan commented 1 year ago

Hey @KulykDmytro I apologize for the delay in getting back to you. For all entities, we essentially show the full name of the entity (as represented in the urn) when that "show full title" button is toggled on. It's not clear to me how we would resolve it differently for each type of data platform (S3, Snowflake, etc), and this seems like a reasonable fallback. Given this, I think we're going to keep this part of the UI as is. I'm going to close out this issue.

Either way, I appreciate you taking the time to bring this to our attention. Thank you!

KulykDmytro commented 1 year ago

@aditya-radhakrishnan looks like glue table have very determined full name: {database}.{table} why not to use it in fullname build for this type of dataset (like it done in any other relational datasets) is it possible to make it work like this or provide such ability in config?

KulykDmytro commented 1 year ago

occasionally i've found another one example of same (Athena table) but with catalog added in the name

i beleive this is not right

treff7es commented 1 year ago

I think it is a valid issue, as we should be consistent in how we ingest Athena urns. Either we should have the catalog name in the urns which comes from DBT and Athena, or not have it, but it should be consistent.

KulykDmytro commented 10 months ago

Any updates on this?