datahub-project / datahub

The Metadata Platform for your Data and AI Stack
https://datahubproject.io
Apache License 2.0
9.99k stars 2.96k forks source link

Support for AWS SSM / Secrets Manager for Spring parameters. #7285

Closed rafa-dot-el closed 1 year ago

rafa-dot-el commented 1 year ago

If possible, add support to AWS SSM and Secrets Manager for all parameters. This can be done by using spring cloud dependency: https://cloud.spring.io/spring-cloud-static/spring-cloud-aws/2.2.0.RELEASE/reference/html/#integrating-your-spring-cloud-application-with-the-aws-parameter-store

Dependency: org.springframework.cloud

I can send the PR, just to confirm that this is the only place where dependencies should be specified: https://github.com/datahub-project/datahub/blob/master/build.gradle

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

rafa-dot-el commented 1 year ago

Issue is not stale, it still being worked on.

rafa-dot-el commented 1 year ago

@david-leifker, can you please check the PR and let me know if this is the correct way of proceeding?

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

rafa-dot-el commented 1 year ago

Issue is not stale, it still being worked on.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

rafa-dot-el commented 1 year ago

This still waiting for review.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

github-actions[bot] commented 1 year ago

This issue was closed because it has been inactive for 30 days since being marked as stale.

rafa-dot-el commented 1 year ago

This still waiting for review.