datahub-project / datahub

The Metadata Platform for your Data Stack
https://datahubproject.io
Apache License 2.0
9.51k stars 2.82k forks source link

batchAddTags only adds tags to one entity #9284

Open jakobhanna opened 8 months ago

jakobhanna commented 8 months ago

Describe the bug Using the graph-ql function mutation batchAddTags only the last entity of the list is updated.

To Reproduce Steps to reproduce the behavior:

  1. Go to datahub-instance...api/graphiql
  2. Use mutation batchAddTags with multiple entities in list for resources:
  3. Check the tags added to the entities
  4. See only the last entity in the last has an added tag

Expected behavior All entities in the list have added tags.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Used the function with DATASET_FIELD entities.

chriscollins3456 commented 7 months ago

@jakobhanna can you share the payload you submitted for this issue? i just tried it myself locally and I was not seeing this same issue myself.

jakobhanna commented 7 months ago

Hi Chris, thanks for the fast reply. Here is my Payload:

mutation batchAddTags {
  batchAddTags(
    input: {
      tagUrns: ["urn:li:tag:PSQ19"], 
      resources: [
        {resourceUrn: "urn:li:dataset:(urn:li:dataPlatform:schema-repo,kpi_,PROD)", 
          subResourceType: DATASET_FIELD, 
          subResource: "[version=2.0].[type=tr069_kpi_schema_].[type=number].received_at"},     
        {resourceUrn: "urn:li:dataset:(urn:li:dataPlatform:schema-repo,kpi_,PROD)", 
          subResourceType: DATASET_FIELD, 
          subResource: "[version=2.0].[type=tr069_kpi_schema_].[type=number].year"}]},

  )

Graph-QL response is:

{
  "data": {
    "batchAddTags": true
  },
  "extensions": {}
}

Bildschirmfoto vom 2023-12-08 12-12-59

Hopefully now you can reproduce or show me, if i am doing something wrong. I attached also a screenshot for you.

Cheers, J

github-actions[bot] commented 6 months ago

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

djrmarques commented 6 months ago

Any update on this? I am currently facing the same issue (v12.0).

github-actions[bot] commented 5 months ago

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

djrmarques commented 5 months ago

Sorry for this, but we are actually a bit blocked by this behavior. Any update/fix coming?

chriscollins3456 commented 5 months ago

@djrmarques sorry for the delay here! i'll be looking into this asap and will update you with what I find. I appreciate your patience but if I can repro (which will be helpful with the payload comment above) then we should be able to get a fix out here!

djrmarques commented 5 months ago

No problem at all, and thanks for taking a look!

chriscollins3456 commented 5 months ago

okay yes confirmed I see the issue here! thanks so much for calling this out. I'll try to knock out the bug this week and it should be included in the next release

jakobhanna commented 5 months ago

Thanks for the great support!!!

djrmarques commented 5 months ago

Thanks a lot! Is there an ETA for the next release?

djrmarques commented 4 months ago

Hey @chriscollins3456 , sorry to ping again, do you know if this ended up getting fixed on v0.13.0? Thank you :)

github-actions[bot] commented 3 months ago

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

usmanovbf commented 3 weeks ago

seems, it is still actual for me too. Regarding the last version of Datahub btw 0.13.1

usmanovbf commented 3 weeks ago

@chriscollins3456 hi Chris! Is there any updated plan to roll out such fix, please? Thank you!