datahub-v2 / frontend

DataHub frontend
https://datahub.io
MIT License
32 stars 11 forks source link

Lockfiles in the repo should be deleted #438

Closed leomrocha closed 4 years ago

leomrocha commented 4 years ago

In the root path of the repository there are two lock files:

That should not have been added to the commit.

Acceptance

rufuspollock commented 4 years ago

@leomrocha lock files should be there - but probably only one (yarn or npm). By defualt i think we go with yarn.

leomrocha commented 4 years ago

OK, sorry, had to delete them to make the system work on local. I will refuse the PR and mark the issue as will not resolve.

Maybe we can edit the documentation in the README to clarify that the lockfile had to be used: something like this:

yarn install --frozen-lock-file # will install exactly what's in yarn.lock without updating it if not yarn refuses the installation

If you approve I will make the change directly in the README.md file on the github editor