datahubio / datahub-v2-pm

Project management (issues only)
8 stars 2 forks source link

Core datasets complex scripts bugs #292

Closed Branko-Dj closed 5 years ago

Branko-Dj commented 5 years ago

https://github.com/datahq/pm/issues/292

As a PM I want to fix the scripts for core datasets that have bugs which have proven more troublesome to fix

Analysis

  1. cofog

Source for process.py script on line 20 access_db_zip_url = 'http://unstats.un.org/unsd/cr/registry/regdntransfer.asp?f=186' is broken. Moving it to broken sources

  1. corruption-perceptions-index

Loads of problems. Libraries need to be installed, sometimes source is downloaded but it is not unzipped, some sources unavailable, it's a mess. I suggest complete refactoring of this script

  1. gdp-us A slight change in url for sources was the problem, easy fix. It might be useful refactoring script to use python 3

  2. geo-admin1-us This uses tuttle file so further analysis is needed

  3. geo-countries This uses tuttle file so further analysis is needed

  4. geo-ne-admin1 This uses tuttle file so further analysis is needed

  5. house-prices-global Format of the source csv file was changed so the script was slightly modified in order to work

  6. house-prices-uk Script is workin properly, the problem was in instructions for running the script in README which is now fixed

  7. imf-weo Unable to make script work, some problem with locales

  8. interest-rates-gb Script works properly but the source is outdated and the script should be refactored

  9. language-codes Unable to make PHP work, further analysis needed

  10. pharmaceutical-drug-spending Fixed importing libraries in population.py

  11. s-and-p-500 In progress as a separate issue

  12. s-and-p-500-companies In progress as a separate issue

  13. un-locode Unable to make PHP work, further analysis needed

  14. world-cities This uses tuttle file so further analysis is needed

Acceptance criteria

Tasks

Branko-Dj commented 5 years ago

Some datasets are fixed, but there are a few complex ones that use PHP and tuttle that will require further analysis and are a part of a separate issue