datahubio / datahub-v2-pm

Project management (issues only)
8 stars 2 forks source link

Automate publication to npm for 2-3 datasets #80

Closed rufuspollock closed 6 years ago

rufuspollock commented 6 years ago

Top level: as a JS/node user i want to import core data into my app natively using the node / js package manager so that I don't have to learn any new tool and i get great data easily.

We have done one dataset by hand. Automate what we did by hand and extend to another 1-2 popular dataset e.g. country-codes currency-codes.

Acceptance criteria

TODO: @Mikanebu proper analysis.

Tasks

Analysis

Since we have created a script with the methods and included json version for data itself. There are some parts need to be done manually.

anuveyatsu commented 6 years ago

@Mikanebu do you think we need to create a script for getting data like we did for country-list dataset? I suppose just letting people to import JSON version of dataset from NPM is good enough so they can work out what they need from that point.

Mikanebu commented 6 years ago

@anuveyatsu ok, when we implemented with @AcckiyGerman we thought it would be nice to have methods to get data... But I think, just providing json would be enough for these datasets. In country-codes there will be too many methods to cover all cases...

AcckiyGerman commented 6 years ago

We created those methods for the backward compatibility (the original npm package had them). There is no need of those methods in new packages I think.

Mikanebu commented 6 years ago

Country-codes is live https://www.npmjs.com/package/@datasets/country-codes

Mikanebu commented 6 years ago

Currency-codes is live https://www.npmjs.com/package/@datasets/currency-codes

rufuspollock commented 6 years ago

@Mikanebu :clap: - can you document how this is automated and where. A big goal here was to automate the process rather than do this by hand (or at least learn how to do that).

/cc @akariv

Mikanebu commented 6 years ago

I cannot automate as I mentioned in my analysis. For now I published country-codes and currency-codes manually.

zelima commented 6 years ago

Moving this to the backlog for now, as it remains untouched.

@Mikanebu could you please describe what exactly is the blocker here? I do not see anything explaining that in the analysis section.

anuveyatsu commented 6 years ago

FIXED for:

anuveyatsu commented 6 years ago

Closing it as FIXED now. We're only waiting for https://github.com/datasets/country-codes/pull/68 to be merged.