datahubio / datahub-v2-pm

Project management (issues only)
8 stars 2 forks source link

Support emojis in markdown #93

Closed rufuspollock closed 6 years ago

rufuspollock commented 6 years ago

As a Developer, I want to be able to use emojis when creating content for DataHub in markdown so that my writings have more interactivity and look better.

Acceptance criteria

Tasks

Analysis

Available NPM packages:

Remaining 2 candidates are both good enough. Node-emoji is more popular and looks like easy-to-use for general purposes. However, markdown-it-emoji is designed specifically for markdown-it processor. Therefore, we choose markdown-it-emoji library as we want to have the quickest and simpliest way of implementing it.

We want to support same list of emojis as Gitter or Github. For that reason we decided to use the same emojifier as Gitter - https://github.com/emojione/emojify.js

To be even more specific we will use Gitter's fork of emoji.js - https://github.com/gitterHQ/emojify.js by simply copying over the main module + images.

anuveyatsu commented 6 years ago

FIXED