datahuborg / datahub

An experimental hosted platform (GitHub-like) for organizing, managing, sharing, collaborating, and making sense of data.
https://datahub.csail.mit.edu
MIT License
210 stars 60 forks source link

AWS migration #69

Closed justinanderson closed 8 years ago

justinanderson commented 8 years ago

Makes vagrant up build whole site that matches the production environment.

RogerTangos commented 8 years ago

Everything looks in place to me. Thank you for updating the documentation. My main reservation is that we're not prompting the user to update their `SECRET_KEY in settings.py. If we're advertising that all they need to do is clone and vagrant up, it seems wise to ask them to provide some entropy.

That aside, seems good. Is that a change you'd like to make, or should we leave it for the next pull request?

justinanderson commented 8 years ago

@RogerTangos Good point. I'll add a SECRET_KEY generator step.

RogerTangos commented 8 years ago

Thanks!

justinanderson commented 8 years ago

Should be all set now.

RogerTangos commented 8 years ago

Looks good. Thanks for storing the key in a seperate file.