[sc-135611] Wait until resources are deleted when deleting a nodegroup

nonatomiclabs commented 1 year ago

This PR fixes a very small bug in the "Resize cluster" macro: when resizing a nodegroup to have 0 nodes, we don't wait until the nodegroup is effectively deleted, but we return once the deletion of the CloudFormation stack is initiated. This might be misleading, so this PR adds the --wait flag to the eksctl delete nodegroup command and to the eksctl scale nodegroup command, to wait until resources are completely deleted or resized.

The wait is controlled by a checkbox in the macro
It applies to both delete and scaling a nodegroup
Waiting during scaling is relatively new to eksctl (only added one month ago), and if you try to use the "wait" with an older version, you see the following error, which is pretty self-explanatory (and you can easily toggle off the wait):

shortcut-integration[bot] commented 1 year ago

This pull request has been linked to Shortcut Story #135611: [EKS] Macro "Resize cluster" returns too early when deleting nodegroup.

nonatomiclabs commented 1 year ago

@marchelleboid good comments indeed, I'm just not sure how to implement this, could you take care of it? 🙂

nonatomiclabs commented 1 year ago

The code Marc added looks good: I installed the new version of the plugin on a fresh instance and can confirm that I could see the two checkboxes and that they behaved as expected. So, LGTM ✅ (I can't "approve" the PR as I was the original author of the change.)

dataiku / dss-plugin-eks-clusters

[sc-135611] Wait until resources are deleted when deleting a nodegroup #47