dataiku / dss-plugin-sharepoint-online

Dataiku DSS plugin to interact with your lists and documents stored on Microsoft SharePoint Online
https://www.dataiku.com/product/plugins/sharepoint-online/
Apache License 2.0
3 stars 4 forks source link

[sc-143215] Adding an "append to list" recipe #47

Closed alexbourret closed 10 months ago

shortcut-integration[bot] commented 1 year ago

This pull request has been linked to Shortcut Story #143215: [SharePoint Online] Keep the list id when overwriting the list's content.

alexbourret commented 10 months ago

Hi @liamlynch-data ! Here are some answers:

  1. This recipe is restricted to append mode. The write_mode selector in recipe.json is hidden ignored in the recipe itself, where the value is forced to append. The option is indeed available in the sync recipe, but until now it is not passed to plugins. (it actually raise an error if used)
  2. Output is mandatory to recipe. The concept of the flow is more about building datasets rather than running the recipes that produce these datasets.
  3. It could be done, we'll discuss it
liamlynch-data commented 10 months ago

Hi @liamlynch-data ! Here are some answers:

  1. This recipe is restricted to append mode. The write_mode selector in recipe.json is hidden ignored in the recipe itself, where the value is forced to append. The option is indeed available in the sync recipe, but until now it is not passed to plugins. (it actually raise an error if used)
  2. Output is mandatory to recipe. The concept of the flow is more about building datasets rather than running the recipes that produce these datasets.
  3. It could be done, we'll discuss it

Re 1 - thanks - I see now I mis-understood the input/output config, where this is selecting it for the DSS dataset output not for the sharepoint one.

  1. I see, I thought it might be something like that.
  2. Ok - not a blocker for this PR though, IMO
liamlynch-data commented 10 months ago

@alexbourret - have you addressed everything you want to now? Shall I re-review?

liamlynch-data commented 10 months ago

@alexbourret that's for those last couple of changes - all looks good, and I did a quick retest and all was still working fine for me.