datainfrahq / druid-operator

Apache Druid On Kubernetes
Other
101 stars 42 forks source link

fix(finalizer): patch finalizers instead of apply #155

Closed itamar-marom closed 6 months ago

itamar-marom commented 6 months ago

Description

Fixes #154

When applying the finalizers, the object generation version is bumped. We don't want that so we're patching the finalizers.


This PR has:


Key changed/added files in this PR
itamar-marom commented 6 months ago

Yes. If you want to feel more confident you can just spawn a kind cluster and create the tiny-cluster. In the old code you will see generation 2, in the new code you will see generation 1

AdheipSingh commented 6 months ago

@itamar-marom nah man , i trust you !