Adds service account name to each druid node optionally

saithal-confluent commented 6 months ago

Adds optional service account name to each druid pod via DruidNode spec

Description

Since Druid components talk to each other and each of them have different identity (different deployments / statefulsets ), we would need different service accounts for each Druid component. However, this is kept optional because its not required by all and the same default service account inherited from the DruidSpec can be used by all.

This PR has:

[x] been tested on a real K8S cluster to ensure creation of a brand new Druid cluster works.
[x] been tested for backward compatibility on a real K*S cluster by applying the changes introduced here on an existing Druid cluster. If there are any backward incompatible changes then they have been noted in the PR description.
[x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[ ] added documentation for new or modified features or behaviors.

Key changed/added files in this PR

MyFoo
OurBar
TheirBaz

AdheipSingh commented 6 months ago

Please resolve conflicts. Also what version of kubebuilder are using ? i see large diff in crd files.

saithal-confluent commented 6 months ago

Please resolve conflicts. Also what version of kubebuilder are using ? i see large diff in crd files.

Reverted to use controller-gen version v0.11.2 and now the diff is minimal.

itamar-marom commented 4 months ago

@saithal-confluent is Confluent using this flavor of the Druid operator?

datainfrahq / druid-operator

Adds service account name to each druid node optionally #164

Description

Key changed/added files in this PR