search

datajerk / c2t

Retro Code (Apple II, Cosmac VIP) to Tape/Text
BSD 3-Clause "New" or "Revised" License
64 stars 11 forks source link

Revert "Refactor appendtone signature" #7

Closed datajerk closed 6 years ago

datajerk commented 6 years ago

Reverts datajerk/c2t#6

Tests failed.

datajerk commented 6 years ago

LOAD ERRERR just getting started.

raphlinus commented 6 years ago

I'm trying to install a test environment so I can run these myself. Test failure was not expected, I'm curious what went wrong.

datajerk commented 6 years ago

Error happens immediately when trying to load the standard 1333 bps protocol, ERR is from the ROM. I do not have the time to compare waveforms of working vs. non-working until later tonight.

raphlinus commented 6 years ago

Yeah, I've got it figured out, the dsk path sets the rate to 48000 but that happens after outbuf_init, so the rates mismatched. I've got it working locally.

datajerk commented 6 years ago

did you want to send a new PR?

raphlinus commented 6 years ago

Yes, I'll send it now.