search

datajoint-company / najafi-2018-nwb

Conversion of Churchland's dataset to NWB 2.0 format
MIT License
4 stars 8 forks source link

NWB RoiResponseSeries does not support trial-segmented data #13

Closed ttngu207 closed 4 years ago

ttngu207 commented 5 years ago

The NWB data of type RoiResponseSeries does not support trial-segmented data format, in the form of (roi x time x trial). RoiResponseSeries expects only 2D data shape (roi x time). In fact, the schema defined in NWB format does not support data storage of trial-segmented form, instead, data should be stored in 2D series (e.g. roi x time, channel x time etc.). Then another 1D vector of trial index can accompany the data time series to specify which trial a particular data sample belongs to (e.g. trial_idx = [1, 1, 1, ..., 1, 2, 2, ..., 2, 3, 3, 4, 4, 4, ...]) The current implementation of RoiResponseSeries in this repository (roi x time x trial) is valid due to an issue in the PyNWB module (https://github.com/NeurodataWithoutBorders/pynwb/pull/813#issuecomment-460402299). The current implementation might become invalid, thus revision is required.

ttngu207 commented 4 years ago

Keep the implementation as is until trial-based data organization becomes standardized in PyNWB