search

datajoint / datajoint-docs

Landing Page for DataJoint Documentation
https://datajoint.com/docs
MIT License
4 stars 11 forks source link

Added a hyperlink to open a chat with our team #32

Closed mkosma closed 1 year ago

mkosma commented 1 year ago

To the PR reviewer: please test that the link I added works properly.

kabilar commented 1 year ago

To the PR reviewer: please test that the link I added works properly.

Thanks @mkosma. We usually request that the submitter ensures that the website deploys correctly by testing locally using the instructions in the readme.

mkosma commented 1 year ago

@kabilar seems to kind of defeat the purpose of an easy "edit" button on the page. I don't have time for install/dev cycles, could one of you that has the environment built please test (or since it's simple, push live, test, iterate if needed)?

CBroz1 commented 1 year ago

I checked the link and, while the chatbot doesn't launch in local deployment, it does change the URL to http://localhost/docs/community/support/#hs-chat-open

@kabilar seems to kind of defeat the purpose of an easy "edit" button on the page. I don't have time for install/dev cycles, could one of you that has the environment built please test (or since it's simple, push live, test, iterate if needed)?

I think I would set a different standard for an outside or first-time contributor. I would check to support someone volunteering in that way, but would ask more of folks in-house

mkosma commented 1 year ago

Thanks. That looks right - and I see your point that it's not otherwise testable in the local environment.

On Wed, Dec 7, 2022 at 4:59 PM Chris Brozdowski @.***> wrote:

I checked the link and, while the chatbot doesn't launch in local deployment, it does change the URL to http://localhost/docs/community/support/#hs-chat-open

@kabilar https://github.com/kabilar seems to kind of defeat the purpose of an easy "edit" button on the page. I don't have time for install/dev cycles, could one of you that has the environment built please test (or since it's simple, push live, test, iterate if needed)?

I think I would set a different standard for an outside or first-time contributor. I would check to support someone volunteering in that way, but would ask more of folks in-house

— Reply to this email directly, view it on GitHub https://github.com/datajoint-company/datajoint-docs/pull/32#issuecomment-1341709578, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAANG2GS2CUEAY6IWTNBG6DWMEJFBANCNFSM6AAAAAASXHVWX4 . You are receiving this because you were mentioned.Message ID: @.***>

mkosma commented 1 year ago

Thanks! Helpful to understand all that.