Css rewrite - Githubissues

datajoint / datajoint-labbook

DataJoint LabBook is a graphical user interface built using React to facilitate working with DataJoint computational pipelines.

https://datajoint.com/docs/core/datajoint-labbook

MIT License

11 stars 14 forks source link

Css rewrite #142

Closed Synicix closed 3 years ago

Synicix commented 3 years ago

Partial rewrite of some CSS to fix odd behavior with scaling and displaying elements. Also fix serval scrolling issues with elements
Fixed flexbox grow issues with safari by adding prefix.

Before tables like this couldn't scroll on safari

With the new changes, the view on safari now matches the original design intended.

Synicix commented 3 years ago

Requesting review on this due to Safari complaints

Synicix commented 3 years ago

@mahos Can I get a review on this, would like to release these fixes at some point.

mahos commented 3 years ago

@mahos Can I get a review on this, would like to release these fixes at some point.

Hey @Synicix sorry about the delay - just checked it out and I'm still having trouble scrolling down on safari for larger tables - not sure if you intended to fix that issue here though, so let me know if I should just approve it, and we work on fixing that safari scroll issue for large tables later on.

========= resolved - docker was having build issue on my end - scroll looks good with the correct version built.

Synicix commented 3 years ago

@guzman-raphael Added pictures

guzman-raphael commented 3 years ago

@Synicix thanks. Is this one now ready to go? I think you mentioned patching another bug but it would be in another PR?

Synicix commented 3 years ago

Yeah, anything that is extra will be on a different PR