datajoint / element-interface

Common functions for the DataJoint Elements
https://datajoint.com/docs
MIT License
3 stars 17 forks source link

Intan loader #73

Closed tdincer closed 1 year ago

tdincer commented 1 year ago

Based on the "One file per channel type format" section of the official intan manual (page 11): https://intantech.com/files/Intan_RHS2000_data_file_formats.pdf

Task list:

For the completeness of the discussion:

kabilar commented 1 year ago

Thanks @tdincer. Drafted this pull request since we wouldn't want to add hardcoded paths to this package.

tdincer commented 1 year ago

@kabilar This PR is to a new branch. It's meant to keep track of the changes. Iterations should be done forking this PR. Not by copy pasting the content.

tdincer commented 1 year ago

@JaerongA and @kabilar I cleaned the code. Let's iterate from here addressing the issues discussed in slack.

tdincer commented 1 year ago

@JaerongA What do we need to return to make this loader useful for array-ephys?

JaerongA commented 1 year ago

@JaerongA What do we need to return to make this loader useful for array-ephys?

The original intan code used to ouput everything (including all the parameters) into a single dictionary format. We might needs parameter values as well. To be completely sure of what's really needed, it'd be worth ingesting some sample data in the element-array-ephys pipeline.

kabilar commented 1 year ago

@kabilar This PR is to a new branch. It's meant to keep track of the changes. Iterations should be done forking this PR. Not by copy pasting the content.

Thanks @tdincer. Whoops, misread the pull request. You are right.