Closed shreelakshmijoshi closed 8 months ago
Build finished.
Removed some unused dependencies. Ran Unit tests to check if removing them caused any errors. Added the vertx, logging, Unit testing, checkstyle-plugin, postgres dependencies to be ignored as unused dependencies. Not sure if we need to remove
org.apache.curator:curator
,io.micrometer:micrometer-registry-prometheus
dependenciesFor issue : #88
Removed some unused dependencies. Ran Unit tests to check if removing them caused any errors. Added the vertx, logging, Unit testing, checkstyle-plugin, postgres dependencies to be ignored as unused dependencies. Not sure if we need to remove
org.apache.curator:curator
,io.micrometer:micrometer-registry-prometheus
dependencies For issue : #88
- micrometer might be needed as it's used for JVM metrics and logs (https://github.com/datakaveri/iudx-acl-apd/blob/3ec32e674f4705a47201479c6a3046aacf7d04e8/src/main/java/iudx/apd/acl/server/deploy/Deployer.java#L190-L200 )
- curator seems to be needed for Zookeeper/Hazelcast when running in clustered mode. But I'm not sure.
Thanks for reviewing the PR. Oh okay, will add it in pom to ignore those dependencies in the warnings
Build finished.
Removed some unused dependencies. Ran Unit tests to check if removing them caused any errors. Added the vertx, logging, Unit testing, checkstyle-plugin, postgres dependencies to be ignored as unused dependencies. Not sure if we need to remove
org.apache.curator:curator
,io.micrometer:micrometer-registry-prometheus
dependenciesFor issue : https://github.com/datakaveri/iudx-acl-apd/issues/88