Closed blakeflei closed 5 months ago
I will decline it if you confirm it runs out of the box now. A fresh build from main seems to solve all the issues.
Also, I'll avoid touching the input data dirs defaults since this was working fine for the Google Drive integration and I intend to keep it compatible. The root directory is the intended location for the build parameters yaml file given it's, in production context, done at build time rather than associated with specific route scenarios.
Did my best to enable an out of the box run. I.e. a
make demo
would run if the user doesn't make any changes, and just clicksClick here to calculate routes
. This didn't work for a few different reasons detailed below (each corresponds to a commit). These were my best guesses, and may need some tweaking to keep in line with the vision of the project.build_parameter.yml
file was expected to be in the same path python is started from, but the container does not start python in the root directory. There may be better solutions that what I've done, but specifying the path tobuild_parameter.yml
as one directory level belowlocal_dir
seems to be resilient to both containerized and host-based runs. It is, however, generally brittle due to being specified in a different location than runs are specified (e.g. will break if another directory layer is added between the data folders and the root directory). This does work for the time being. Is the root directory wherebuild_parameter.yml
should be located?/data{session_id}
folder, which is not the same as theWORKING_DATA_DIR
path. Updated theINPUT_DATA_DIR
to correctly reflect this (I think this is intended behavior given the upload paths created by the streamlit app). Also, for the out of the box (oob) behavior, there is no session id, soget_solution()
was updated to enable oob runs. *request_solution()
anddownload_solution()
were also updated to enable oob runs.Address Issue 60.