datakind / dk-routing

Container-based Action Routing Tool (CART)
MIT License
8 stars 11 forks source link

Enable CART to run out of the box #61

Closed blakeflei closed 5 months ago

blakeflei commented 5 months ago

Did my best to enable an out of the box run. I.e. a make demo would run if the user doesn't make any changes, and just clicks Click here to calculate routes. This didn't work for a few different reasons detailed below (each corresponds to a commit). These were my best guesses, and may need some tweaking to keep in line with the vision of the project.

Address Issue 60.

Zebreu commented 5 months ago

I will decline it if you confirm it runs out of the box now. A fresh build from main seems to solve all the issues.

Zebreu commented 5 months ago

Also, I'll avoid touching the input data dirs defaults since this was working fine for the Google Drive integration and I intend to keep it compatible. The root directory is the intended location for the build parameters yaml file given it's, in production context, done at build time rather than associated with specific route scenarios.

blakeflei commented 5 months ago

Thanks so much for providing input and addressing the concerns!

Running from the dkroutingtool directory addresses the first two points, and PR 62 addresses the last two points. I'll mark this one closed. Thanks!