Closed bdewilde closed 1 year ago
thanks for taking a look @samanz . here are the use cases i'd like to support:
cool, and when you say "it doesn't totally work" what isn't working now?
that comment was left regarding an older version of these changes -- a few commits back -- and i don't remember exactly what i was referring to. probably that i couldn't access the api via a web browser, it was saying that the connection had been reset; that is no longer the case, fortunately. i can say that, using the latest revision of this branch, the worker service dies immediately, which is not ideal.
would it be easier if i just merged this into dev, then started hacking on a new branch? i really want to set up a basic unit testing suite -- and maybe the current setup here will work for that? not sure -- and then blacken the entire code base. not sure if you have other work that goes better in parallel, or are you a bit blocked by those two steps as well?
I do eventually want to move the scala code to python, and I would just add that to the flask API. I want to wait until you have things stabilized here before starting that work. I can work on testing models independently though, so not blocked on working on anything. I'd be nice if we can have the docker setup be stable, and that can be the version we launch on the staging box. It'll also make my development env setup easier. I'm happy to help get the docker env up.
i would love some help in getting the docker setup -- part of the stabilization project -- working as expected, since i don't have much experience with it. to that end, i'll merge these changes into dev, then start a new branch+PR focused on docker stuff that we can both hack on. part of that will hopefully be basic unit testing and usage instructions leveraging the docker builds. will tag you over there....
changes
pyproject.toml
into prod/dev requirements files, which are intended only for better caching docker buildsquestions