Minor KWIC tweaks - Githubissues

datalab-dev / quintessence_web_app

Repository for the Quintessence Web Project applying Topic Models and Word Embeddings to EEBO-TCP

http://quintessence.ds.lib.ucdavis.edu/

0 stars 0 forks source link

Minor KWIC tweaks #7

Closed sampizelo closed 4 years ago

sampizelo commented 5 years ago

[x] some mechanism for viewing documents with keyword that do not appear in truncated form of document (e.g. "transmutation" for an example).
[x] KWIC search looks for pattern without looking for spaces (I think) - e.g. "science" returns a document with "conscience" highlighted.

sampizelo commented 4 years ago

@cnagda I think you fixed both of these (above), but I just wanted to confirm before closing the issue.

[x] One other tiny KWIC tweak: We should include "Word in Context: <//br>" in default KWIC layout using the same grey&bold font from metadata.

cnagda commented 4 years ago

Above is fixed and word in context should appear with the same layout now. For reference kwic text is now passed in to get_meta() as an optional arg, then added to the get_meta php response before parsing. There was probably a better way to do that but eventually all the document results js should probably go in some sort of utils and be a little more split up since it is used on multiple pages.

sampizelo commented 4 years ago

Ok awesome! Thanks. I'll close the issue now.