datalab-org / datalab

datalab is a place to store experimental data and the connections between them.
https://docs.datalab-org.io
MIT License
49 stars 17 forks source link

Add 'optical' cellFormat #788

Closed BenjaminCharmes closed 4 months ago

BenjaminCharmes commented 4 months ago

Close #787

Added 'optical' to cell formats

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.17%. Comparing base (bb141a6) to head (35b7be0).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #788 +/- ## ======================================= Coverage 67.16% 67.17% ======================================= Files 62 62 Lines 3828 3829 +1 ======================================= + Hits 2571 2572 +1 Misses 1257 1257 ``` | [Files](https://app.codecov.io/gh/the-grey-group/datalab/pull/788?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=the-grey-group) | Coverage Δ | | |---|---|---| | [pydatalab/pydatalab/models/cells.py](https://app.codecov.io/gh/the-grey-group/datalab/pull/788?src=pr&el=tree&filepath=pydatalab%2Fpydatalab%2Fmodels%2Fcells.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=the-grey-group#diff-cHlkYXRhbGFiL3B5ZGF0YWxhYi9tb2RlbHMvY2VsbHMucHk=) | `90.56% <100.00%> (+0.18%)` | :arrow_up: |
cypress[bot] commented 4 months ago

Passing run #1990 ↗︎

0 40 0 0 Flakiness 0

Details:

Merge 35b7be0af94a81c06a34768a816e387bc9bbb122 into bb141a61b106122e76f83ff26f45...
Project: datalab Commit: 027310d51e ℹ️
Status: Passed Duration: 02:13 💡
Started: Jul 3, 2024 1:13 PM Ended: Jul 3, 2024 1:15 PM

Review all test suite changes for PR #788 ↗︎

ml-evs commented 4 months ago

pre-commit.ci run

ml-evs commented 4 months ago

Ah the problem is that pre-commit CI cannot run the schema linter (I think). I'll manually run this.

BenjaminCharmes commented 4 months ago

Pending pre-commit run, this lgtm, is it ready to merge @BenjaminCharmes?

Yes !