Closed ml-evs closed 2 weeks ago
Attention: Patch coverage is 89.47368%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 67.33%. Comparing base (
1b05dfe
) to head (955216d
). Report is 1 commits behind head on main.
Attention: Patch coverage is 83.33333%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 68.14%. Comparing base (
5bd7e24
) to head (b88194c
). Report is 1 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
pydatalab/pydatalab/routes/v0_1/items.py | 83.33% | 1 Missing :warning: |
Passed #2337
•
a855ce461b ℹ️: Merge b88194cffa16450126b083fde20ba537eb094937 into 5bd7e24356853cf65364e531a886...
Project |
datalab
|
Branch Review |
ml-evs/qr-codes
|
Run status |
Passed #2337
|
Run duration | 04m 33s |
Commit |
a855ce461b ℹ️: Merge b88194cffa16450126b083fde20ba537eb094937 into 5bd7e24356853cf65364e531a886...
|
Committer | Matthew Evans |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
132
|
View all changes introduced in this branch ↗︎ |
Closes #803.
This PR:
{{ QR_CODE_RESOLVER_URL }}/items/<refcode>
, which can be configured. The refcode itself is always parseable from this URL, so datalab-native scanners (such as that described below) can resolve the item without needing to go via the resolver.redirect-to-ui
, where the/items
endpoint can point itself to the UI, if configured. This is the default redirect used by the purl system.Potential follow-ups: