search

datalab-org / datalab

datalab is a place to store experimental data and the connections between them.
https://docs.datalab-org.io
MIT License
42 stars 17 forks source link

Add API route to add items to a collection and associated UI #828

Closed BenjaminCharmes closed 3 days ago

BenjaminCharmes commented 1 month ago

Closes #819

Add functionality to /collections route to receive and add a list of items to a list of collections inside the new next DataTable for samples

cypress[bot] commented 1 month ago

datalab    Run #2393

Run Properties:  status check passed Passed #2393  •  git commit 21c6290933 ℹ️: Merge ccb72ee8305b73b3f15d68378faaefde8bb261af into 29af4906d56d70735b26b3bae3e8...
Project datalab
Branch Review bc/new-collections_route
Run status status check passed Passed #2393
Run duration 06m 51s
Commit git commit 21c6290933 ℹ️: Merge ccb72ee8305b73b3f15d68378faaefde8bb261af into 29af4906d56d70735b26b3bae3e8...
Committer Benjamin Charmes
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 393
View all changes introduced in this branch ↗︎
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.22%. Comparing base (29af490) to head (ccb72ee). Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pydatalab/pydatalab/routes/v0_1/collections.py 89.47% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #828 +/- ## ========================================== + Coverage 68.12% 68.22% +0.10% ========================================== Files 62 62 Lines 3890 3909 +19 ========================================== + Hits 2650 2667 +17 - Misses 1240 1242 +2 ``` | [Files with missing lines](https://app.codecov.io/gh/datalab-org/datalab/pull/828?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalab-org) | Coverage Δ | | |---|---|---| | [pydatalab/pydatalab/routes/v0\_1/collections.py](https://app.codecov.io/gh/datalab-org/datalab/pull/828?src=pr&el=tree&filepath=pydatalab%2Fpydatalab%2Froutes%2Fv0_1%2Fcollections.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalab-org#diff-cHlkYXRhbGFiL3B5ZGF0YWxhYi9yb3V0ZXMvdjBfMS9jb2xsZWN0aW9ucy5weQ==) | `69.53% <89.47%> (+3.47%)` | :arrow_up: |
ml-evs commented 1 week ago

pre-commit.ci run

ml-evs commented 1 week ago

pre-commit.ci autofix

ml-evs commented 3 days ago

pre-commit.ci autofix

BenjaminCharmes commented 3 days ago

Thanks for the review @ml-evs, everything should be good now.