search

datalab-org / datalab

datalab is a place to store experimental data and the connections between them.
https://docs.datalab-org.io
MIT License
46 stars 17 forks source link

User select and sharing of sample page with creators #830

Open ml-evs opened 2 months ago

ml-evs commented 2 months ago

This PR will add a user select and editable option to the creator list for items.

It should prevent the user from removing themselves at the JS level, and should potentially prevent the user from removing other people (i.e. append-only share), or some more tortured logic where the "first" creator in the list takes precedence.

This may require some additional API routes.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 88.57143% with 4 lines in your changes missing coverage. Please review.

Project coverage is 68.42%. Comparing base (39be3fb) to head (a055f7a).

Files with missing lines Patch % Lines
pydatalab/pydatalab/routes/v0_1/items.py 88.57% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #830 +/- ## ========================================== + Coverage 68.22% 68.42% +0.19% ========================================== Files 62 62 Lines 3909 3943 +34 ========================================== + Hits 2667 2698 +31 - Misses 1242 1245 +3 ``` | [Files with missing lines](https://app.codecov.io/gh/datalab-org/datalab/pull/830?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalab-org) | Coverage Δ | | |---|---|---| | [pydatalab/pydatalab/routes/v0\_1/items.py](https://app.codecov.io/gh/datalab-org/datalab/pull/830?src=pr&el=tree&filepath=pydatalab%2Fpydatalab%2Froutes%2Fv0_1%2Fitems.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalab-org#diff-cHlkYXRhbGFiL3B5ZGF0YWxhYi9yb3V0ZXMvdjBfMS9pdGVtcy5weQ==) | `83.60% <88.57%> (+0.94%)` | :arrow_up: |
cypress[bot] commented 2 months ago

datalab    Run #2473

Run Properties:  status check failed Failed #2473  •  git commit 0b7790547d ℹ️: Merge a055f7a737b1bb311b27f0c9f244d7652ea6e899 into 39be3fb056179b66d37cf2de259a...
Project datalab
Branch Review ml-evs/creators-ui
Run status status check failed Failed #2473
Run duration 05m 03s
Commit git commit 0b7790547d ℹ️: Merge a055f7a737b1bb311b27f0c9f244d7652ea6e899 into 39be3fb056179b66d37cf2de259a...
Committer Matthew Evans
View all properties for this run ↗︎
Test results
Tests that failed  Failures 3
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 129
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/editPage.cy.js • 1 failed test • End-to-end tests (chrome) View Output
Test Artifacts
Edit Page > Add some blocks to the sample and checks unsaved warning behavior Test Replay Screenshots
Failed  cypress/e2e/editPage.cy.js • 1 failed test • End-to-end tests (electron) View Output
Test Artifacts
Edit Page > Add some blocks to the sample and checks unsaved warning behavior Test Replay Screenshots
Failed  cypress/e2e/editPage.cy.js • 1 failed test • End-to-end tests (firefox) View Output
Test Artifacts
Edit Page > Add some blocks to the sample and checks unsaved warning behavior Screenshots