search

datalab-org / datalab

datalab is a place to store experimental data and the connections between them.
https://docs.datalab-org.io
MIT License
49 stars 17 forks source link

Fix and refactor FTS field generation #998

Closed ml-evs closed 2 weeks ago

ml-evs commented 2 weeks ago

Closes #997, and is related to #993

This PR improves how we choose which fields to use in the FTS.

Previously, some IDs were being included, which will no longer happen.

Also, some field names were being added by aliases that are not present in the database, so were excluded (mostly starting materials fields).

cypress[bot] commented 2 weeks ago

datalab    Run #2754

Run Properties:  status check passed Passed #2754  •  git commit 4aeb75bf57 ℹ️: Merge 6a8feac9c4a9f8159743efb294cc596366ad5da6 into 0cca3103c7bf20d2d106896222d1...
Project datalab
Branch Review ml-evs/fix-fts-fields
Run status status check passed Passed #2754
Run duration 10m 30s
Commit git commit 4aeb75bf57 ℹ️: Merge 6a8feac9c4a9f8159743efb294cc596366ad5da6 into 0cca3103c7bf20d2d106896222d1...
Committer Matthew Evans
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 405
View all changes introduced in this branch ↗︎
codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.35%. Comparing base (0cca310) to head (6a8feac). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #998 +/- ## ========================================== - Coverage 68.38% 68.35% -0.04% ========================================== Files 62 62 Lines 3941 3937 -4 ========================================== - Hits 2695 2691 -4 Misses 1246 1246 ``` | [Files with missing lines](https://app.codecov.io/gh/datalab-org/datalab/pull/998?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalab-org) | Coverage Δ | | |---|---|---| | [pydatalab/src/pydatalab/models/entries.py](https://app.codecov.io/gh/datalab-org/datalab/pull/998?src=pr&el=tree&filepath=pydatalab%2Fsrc%2Fpydatalab%2Fmodels%2Fentries.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalab-org#diff-cHlkYXRhbGFiL3NyYy9weWRhdGFsYWIvbW9kZWxzL2VudHJpZXMucHk=) | `82.75% <ø> (ø)` | | | [pydatalab/src/pydatalab/mongo.py](https://app.codecov.io/gh/datalab-org/datalab/pull/998?src=pr&el=tree&filepath=pydatalab%2Fsrc%2Fpydatalab%2Fmongo.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalab-org#diff-cHlkYXRhbGFiL3NyYy9weWRhdGFsYWIvbW9uZ28ucHk=) | `79.10% <100.00%> (-1.18%)` | :arrow_down: |