search

datalad-datasets / ohbm2020-posters

Centralized registry of Jitsi rooms and pdfs for OHBM 2020 posters.
https://datalad-datasets.github.io/ohbm2020-posters
32 stars 84 forks source link

convert github.com raw url to raw.githack.com url / adding etherpad on the right #163

Closed soichih closed 4 years ago

soichih commented 4 years ago

ref https://github.com/datalad-datasets/ohbm2020-posters/pull/143

This update converts github raw url (that doesn't set content-type) to raw.githack.com url so that user can open the pdf directly on the browser.

soichih commented 4 years ago

image

The etherpad tries to address these issues REF https://github.com/datalad-datasets/ohbm2020-posters/issues/127 https://github.com/datalad-datasets/ohbm2020-posters/issues/157 (somewhat)

yarikoptic commented 4 years ago

could not test locally, even if I allow cookies for 127.0.0.1 chromium doesn't really record it and I come back to

An error occurred
Please press and hold Ctrl and press F5 to reload this page
If the problem persists please send this error message to your webmaster:

ErrorId: trC36oQ4gYH2Mk17yHq0
URL: https://etherpad.wikimedia.org/p/ohbm2020-3
UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.116 Safari/537.36
Uncaught TypeError: Cannot read property 'setStateIdle' of null in https://etherpad.wikimedia.org/javascripts/lib/ep_etherpad-lite/static/js/pad.js?callback=require.define&v=2eb54623 at line 3

even going to localhost doesn't help... will deploy/test tomorrow. If PDF was a separate PR - would have been easier to review/merge

yarikoptic commented 4 years ago

and going back to df7edb282a0e3364fa51e87e09a7136143731a87 before presumably etherpad addition - doesn't work

soichih commented 4 years ago

Does it work on my fork? https://soichi.us/ohbm2020-posters/#/room/3/ohbm2020-3

yarikoptic commented 4 years ago

Nope (although this time coming from phone not laptop) - similar cookie issue

soichih commented 4 years ago

I just tested with a few people and they all seemed to work.. on my fork. I am wondering if the issue is caused by your browser / OS?

[image: image.png]

I did forget to hide the note for mobile.. so I will do that now.

On Thu, Jul 2, 2020 at 8:51 AM Yaroslav Halchenko notifications@github.com wrote:

Nope (although this time coming from phone not laptop) - similar cookie issue

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/datalad-datasets/ohbm2020-posters/pull/163#issuecomment-652986765, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHBR6ENDYVJBG6LVGTS5ODRZR7E5ANCNFSM4OODUIFA .

yarikoptic commented 4 years ago

from your clone:

I wonder if there could be at least a message (e.g. instead of error msg) in such cases instructing user to do that (add etherpad.wikimedia.org or allow for third-party cookies). I am not sure why chromium doesn't ask me explicitly for cookies from that website to be allowed or not.

soichih commented 4 years ago

Actually.. I was able to recreate this problem on some posters (happens on 1966 consistently).

It looks like etherpad is trying to send some warning message through "top" property. 

                r[t] = i(function() {
                    "setAuthorInfo" !== t || arguments[0] ? d[n + t].apply(this, arguments) : top.console.warn("setAuthorInfo AuthorId not set for some reason", arguments)
                })

I don't know 1) what AuthorId is, why it's not set and how to set it. 2) why this only happens on 1966, 3) if this is a bug with etherpad itself.. I don't think it should be accessing window.top to post messages like that.

yarikoptic commented 4 years ago

submit issue to etherpad and see what they say?

soichih commented 4 years ago

I've looked and it looks like they've already fixed it.

https://github.com/ether/etherpad-lite/blob/c5584fb5b41a67704bcad4178a5420377b6988ab/src/static/js/ace2_inner.js#L344

Also, I just refreshed 1966 and now it's working again.. :( I am guessing wikimedia.org has some old code stuck in one of their servers, or CDN.. or something)

yarikoptic commented 4 years ago

FWIW, twitted: