search

datalad-handbook / book

Sources for the DataLad handbook
http://handbook.datalad.org
Other
143 stars 56 forks source link

Fixes to the S3 walk-through #1231

Closed adswa closed 3 months ago

adswa commented 3 months ago

This incorporates the corrected commands and information from #1224. Fixes #1224.

adswa commented 3 months ago

hey @all-contributors please add @NickleDave for bug, content

allcontributors[bot] commented 3 months ago

@adswa

I've put up a pull request to add @NickleDave! :tada:

adswa commented 3 months ago

There is, however, a caveat that the git-annex available currently in debian-stable does not recognize the publicurl parameter, and blindly follows public 🙈 I think this is worth another find-out-more. See also https://github.com/datalad-handbook/book/issues/1224#issuecomment-2155481884.

I have added a version note to the top of the page, and I also linked the discussion in it.

I believe we should also mention the publicurl git-annex parameter. Otherwise, I think git-annex would use s3 protocol, and I am not sure if it does it anonymously. See its description in git-annex S3 manpage.

Do you mean beyond the description prior to enableremote?

I realize I haven't mentioned the bucket policies - I will read up on what they are and add a findoutmore on them.

mslw commented 3 months ago

Ah, sorry, publicurl has already been there, I focused on the diff, and the part which removed public -- but at that stage in the chapter we are assuming that everything is private.

So it isn't exactly as bad as what I said (that older annex does not recognize publicurl at all -- it does not recognize it when public=no). You can check again whether the important note at the top is not too strict (because of me), but otherwise I retract my request for changes :-)