Closed mslw closed 1 year ago
Thanks for picking this up @mslw
Not sure about the first, whether the logger should be renamed to datalad.catalog.extractors.datacite_gin or whether it's desirable to keep it. I kept it.
I am not sure about "desirable", but I basically just copied the approach in the studyminimeta extractor. Either way is probably fine. So I think we can leave it until there some reason that it should definitely be changed.
The
datalad.metadata
module was removed from DataLad 0.18 and added to MetaLad 0.4.6. It was imported only once in the catalog codebase (and only to get a single constant). Switching the import will restore compatibility with datalad 0.18.This also bumps the required patch version of Metalad.
Fixes #238 and should resolve #239.
Note, there are still two matches within the catalog module:
The second is I think OK, as it refers to entry point name. Not sure about the first, whether the logger should be renamed to
datalad.catalog.extractors.datacite_gin
or whether it's desirable to keep it. I kept it.