datalad / datalad-catalog

Create a user-friendly data catalog from structured metadata
https://datalad-catalog.netlify.app
MIT License
15 stars 12 forks source link

ENH: don't install jq dependency on windows #248

Closed jsheunis closed 1 year ago

jsheunis commented 1 year ago

jq building is failing on windows during appveyor testing.

This PR ensures:

import platform

if platform.system() == 'Windows':
    collect_ignore_glob = ["*workflow.py", "*workflows.py"]
codecov-commenter commented 1 year ago

Codecov Report

Base: 82.47% // Head: 82.75% // Increases project coverage by +0.28% :tada:

Coverage data is based on head (601a6a5) compared to base (06623fb). Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #248 +/- ## ========================================== + Coverage 82.47% 82.75% +0.28% ========================================== Files 25 26 +1 Lines 1603 1606 +3 ========================================== + Hits 1322 1329 +7 + Misses 281 277 -4 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `69.25% <75.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/datalad/datalad-catalog/pull/248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad) | Coverage Δ | | |---|---|---| | [conftest.py](https://codecov.io/gh/datalad/datalad-catalog/pull/248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-Y29uZnRlc3QucHk=) | `66.66% <66.66%> (ø)` | | | [datalad\_catalog/tests/test\_workflow.py](https://codecov.io/gh/datalad/datalad-catalog/pull/248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9jYXRhbG9nL3Rlc3RzL3Rlc3Rfd29ya2Zsb3cucHk=) | `99.17% <100.00%> (+<0.01%)` | :arrow_up: | | [datalad\_catalog/\_version.py](https://codecov.io/gh/datalad/datalad-catalog/pull/248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9jYXRhbG9nL192ZXJzaW9uLnB5) | `46.59% <0.00%> (+1.59%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jsheunis commented 1 year ago

Closes https://github.com/datalad/datalad-catalog/issues/224