datalad / datalad-catalog

Create a user-friendly data catalog from structured metadata
https://datalad-catalog.netlify.app
MIT License
15 stars 12 forks source link

codespell: typo fixes, config, workflow #257

Closed yarikoptic closed 1 year ago

yarikoptic commented 1 year ago

oh, appveyor fails , seems a result of my fixups here -- was tricky to do them in those bigonelined json files.

        keys_to_test = [
            "authors",
            "children",
            "description",
            "funding",
            "keywords",
            "publications",
            "license",
            "name",
            "type",
        ]
>       assert_dict_values_equal(generated_meta, correct_meta, keys_to_test)
../datalad_catalog/tests/test_workflow.py:444: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
../datalad_catalog/tests/test_workflow.py:490: in assert_dict_values_equal
    assert_equal(dict_to_test[key], dict_correct[key])
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
first = '"Extension of the dataset published in Hanke et al.\n (2014; doi:10.1038/sdata.2014.3) with additional acquisitions f...-German CRCNS project,\n co-funded by the BMBF and the US National Science Foundation\n (BMBF 01GQ1411; NSF 1429999)."'
second = '"Extension of the dataset published in Hanke et al.\n (2014; doi:10.1038/sdata.2014.3) with additional acquisitions f...-German CRCNS project,\n co-funded by the BMBF and the US National Science Foundation\n (BMBF 01GQ1411; NSF 1429999)."'

will try tolook into it later unless @jsheunis beats me to it ;)

yarikoptic commented 1 year ago

FWIW, allowed to fix typos in json and fixed them automagically - let's see if helps

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3c43207) 82.81% compared to head (c0a0fab) 82.81%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #257 +/- ## ======================================= Coverage 82.81% 82.81% ======================================= Files 32 32 Lines 2147 2147 ======================================= Hits 1778 1778 Misses 369 369 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `72.26% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/datalad/datalad-catalog/pull/257?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad) | Coverage Δ | | |---|---|---| | [datalad\_catalog/\_version.py](https://codecov.io/gh/datalad/datalad-catalog/pull/257?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9jYXRhbG9nL192ZXJzaW9uLnB5) | `46.59% <ø> (ø)` | | | [datalad\_catalog/catalog.py](https://codecov.io/gh/datalad/datalad-catalog/pull/257?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9jYXRhbG9nL2NhdGFsb2cucHk=) | `80.11% <ø> (ø)` | | | [datalad\_catalog/tests/test\_workflow.py](https://codecov.io/gh/datalad/datalad-catalog/pull/257?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9jYXRhbG9nL3Rlc3RzL3Rlc3Rfd29ya2Zsb3cucHk=) | `89.05% <ø> (ø)` | | | [datalad\_catalog/webcatalog.py](https://codecov.io/gh/datalad/datalad-catalog/pull/257?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9jYXRhbG9nL3dlYmNhdGFsb2cucHk=) | `90.29% <ø> (ø)` | | | [datalad\_catalog/tests/test\_config.py](https://codecov.io/gh/datalad/datalad-catalog/pull/257?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9jYXRhbG9nL3Rlc3RzL3Rlc3RfY29uZmlnLnB5) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jsheunis commented 1 year ago

Thanks @yarikoptic!