datalad / datalad-catalog

Create a user-friendly data catalog from structured metadata
https://datalad-catalog.netlify.app
MIT License
14 stars 12 forks source link

Fix datacite_gin publication doi translation #325

Closed mslw closed 1 year ago

mslw commented 1 year ago

This is a small tweak to datacite_gin_translator that will:

FMPOV this should be enough to close #322 as it answers the original problem -- unless you do want to add more formatting rules to JS.

Ping https://github.com/psychoinformatics-de/sfb1451-projects-catalog/issues/23

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (f612cb1) 82.32% compared to head (abd9d39) 82.32%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #325 +/- ## ======================================= Coverage 82.32% 82.32% ======================================= Files 32 32 Lines 2173 2173 ======================================= Hits 1789 1789 Misses 384 384 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `71.76% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/datalad/datalad-catalog/pull/325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad) | Coverage Δ | | |---|---|---| | [...lad\_catalog/translators/datacite\_gin\_translator.py](https://app.codecov.io/gh/datalad/datalad-catalog/pull/325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9jYXRhbG9nL3RyYW5zbGF0b3JzL2RhdGFjaXRlX2dpbl90cmFuc2xhdG9yLnB5) | `100.00% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.