datalad / datalad-catalog

Create a user-friendly data catalog from structured metadata
https://datalad-catalog.netlify.app
MIT License
14 stars 12 forks source link

test_workflow_new fails again in datalad-extensions testing #329

Closed yarikoptic closed 1 month ago

yarikoptic commented 1 year ago

There was https://github.com/datalad/datalad-catalog/issues/239 which was addressed much earlier in the year, so I would assume that it was fixed -- there was a gap before datalad-catalog started to fail

10645     Jun 14 Yaroslav Halche *-4.7* ( 36K/0) [datalad/datalad-extensions] Run failed: test-datalad_catalog-master - master (8d68e91)                                                                             
16281     May 18 Yaroslav Halche *-4.8* ( 35K/0) [datalad/datalad-extensions] Run failed: test-datalad_catalog-master - master (8d68e91) 

we do have datalad-catalog failing now e.g. https://github.com/datalad/datalad-extensions/actions/runs/5652017966/job/15311002680

=========================== short test summary info ============================
FAILED tests/test_workflow.py::test_workflow_new - AssertionError: assert False
 +  where False = <bound method Path.exists of PosixPath('/tmp/datalad_temp_tree_test_workflow_newg66ykbf4/translated_meta.json')>()
 +    where <bound method Path.exists of PosixPath('/tmp/datalad_temp_tree_test_workflow_newg66ykbf4/translated_meta.json')> = (PosixPath('/tmp/datalad_temp_tree_test_workflow_newg66ykbf4') / 'translated_meta.json').exists
 +      where PosixPath('/tmp/datalad_temp_tree_test_workflow_newg66ykbf4') = Path('/tmp/datalad_temp_tree_test_workflow_newg66ykbf4')
 +        where '/tmp/datalad_temp_tree_test_workflow_newg66ykbf4' = Dataset('/tmp/datalad_temp_tree_test_workflow_newg66ykbf4').path
=================== 1 failed, 40 passed, 6 warnings in 9.47s ===================
Error: Process completed with exit code 1.

a quick fix and release would be appreciated to stop me being bombarded with emails

jsheunis commented 1 year ago

Thanks @yarikoptic will look into this

jsheunis commented 1 month ago

This was fixed at some point in the past year :)