ENH: Updates functioning of catalog home button

jsheunis commented 8 months ago

This adds improved logic to the function called when user selects the home button: (this applies when the current location is any tab on any dataset page in a catalog)

If there is NO home page set:
- if there is a tab name in the URL, navigate to current
- else: don't navigate, only reset
If there IS a home page set:
- if the current page IS the home page:
  - if there is a tab name in the URL, navigate to current
  - else: don't navigate, only reset
- if the current page is NOT the home page, navigate to home (reset = clear filters and set tab index = 0)

Closes https://github.com/datalad/datalad-catalog/issues/390

jsheunis commented 8 months ago

damn, now what's up with metalad on windows :( https://ci.appveyor.com/project/mih/datalad-catalog/builds/48265221/job/osu78mqs5at52nou

jsheunis commented 8 months ago

Since the appveyor failure issue is tracked separately in metalad, and it is not influenced by or a prerequisite for code, this PR can be merged

christian-monch commented 5 months ago

damn, now what's up with metalad on windows :( https://ci.appveyor.com/project/mih/datalad-catalog/builds/48265221/job/osu78mqs5at52nou

This should be fixed by release 0.14.20 of datalad-metalad.

jsheunis commented 5 months ago

Thanks @christian-monch !

datalad / datalad-catalog

ENH: Updates functioning of catalog home button #394