datalad / datalad-catalog

Create a user-friendly data catalog from structured metadata
https://datalad-catalog.netlify.app
MIT License
15 stars 12 forks source link

Changes to vue router history mode in order to improve SEO #420

Closed jsheunis closed 7 months ago

jsheunis commented 7 months ago

This includes several diffs, including some patches dealing with the fallout:

See https://github.com/psychoinformatics-de/sfb1451-projects-catalog/pull/83 for more context.

Closes https://github.com/datalad/datalad-catalog/issues/20

netlify[bot] commented 7 months ago

Deploy Preview for rad-marigold-e22f36 ready!

Name Link
Latest commit 8986c5317ca45c90d5ac44d0a5fc10a04415262e
Latest deploy log https://app.netlify.com/sites/rad-marigold-e22f36/deploys/65c54583218bd00008928429
Deploy Preview https://deploy-preview-420--rad-marigold-e22f36.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov-commenter commented 7 months ago

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (15be13d) 84.75% compared to head (8986c53) 84.67%.

Files Patch % Lines
datalad_catalog/webcatalog.py 0.00% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #420 +/- ## ========================================== - Coverage 84.75% 84.67% -0.09% ========================================== Files 45 45 Lines 2880 2884 +4 ========================================== + Hits 2441 2442 +1 - Misses 439 442 +3 ``` | [Flag](https://app.codecov.io/gh/datalad/datalad-catalog/pull/420/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/datalad/datalad-catalog/pull/420/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad) | `78.04% <0.00%> (-0.11%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.