search

datalad / datalad-catalog

Create a user-friendly data catalog from structured metadata
https://datalad-catalog.netlify.app
MIT License
14 stars 12 forks source link

Remove void statement which can cause errors #451

Closed mslw closed 1 month ago

mslw commented 2 months ago

I think (but please verify) that these two lines should be removed, because the actual handling of "homepage" seems to happen a few lines above, and uses optional chaining (?.). If left in, they cause errors when the additional display does not contain "homepage".

This should fix #450

netlify[bot] commented 2 months ago

Deploy Preview for datalad-catalog ready!

Name Link
Latest commit 274c04131f074b26a172d2844f4ccb40e7b9e9e3
Latest deploy log https://app.netlify.com/sites/datalad-catalog/deploys/66318cfaf30a720008ed7b7e
Deploy Preview https://deploy-preview-451--datalad-catalog.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.50%. Comparing base (821b12f) to head (274c041).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #451 +/- ## ======================================= Coverage 83.50% 83.50% ======================================= Files 43 43 Lines 2897 2897 ======================================= Hits 2419 2419 Misses 478 478 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jsheunis commented 1 month ago

Thanks @mslw ! Looks like sound reasoning to me.