search

datalad / datalad-catalog

Create a user-friendly data catalog from structured metadata
https://datalad-catalog.netlify.app
MIT License
14 stars 12 forks source link

Fix notebook handling #453

Closed mslw closed 1 month ago

mslw commented 1 month ago

This PR fixes errors in handling custom notebook information (the ability was introduced as part of #440). No tracing issue because the fixes are small.

It also fixes a black formatting inconsistency picked by CI (2024 stable style requires empty line after module docstring) also seen in a few recent PRs.

See Individual commits for details.

netlify[bot] commented 1 month ago

Deploy Preview for datalad-catalog ready!

Name Link
Latest commit 5fc9356102a671d577fa40c18e218eca97b73436
Latest deploy log https://app.netlify.com/sites/datalad-catalog/deploys/663deefa68931f00085c74fe
Deploy Preview https://deploy-preview-453--datalad-catalog.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.50%. Comparing base (80d8224) to head (5fc9356).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #453 +/- ## ======================================= Coverage 83.50% 83.50% ======================================= Files 43 43 Lines 2897 2897 ======================================= Hits 2419 2419 Misses 478 478 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jsheunis commented 1 month ago

Thanks @mslw! This looks good. I merged main and will merge now.