Open jsheunis opened 2 years ago
I'm noting a few general TODOs and antipatterns that need to be worked on.
msg = f"here is something of importance for {var}"
yield dict(
... ,
message = mgs,
)
do
yield dict(
... ,
message = (
"Here is something of importance for %s",
var
)
)
abspath(curdir)
, which might not in all cases refer to the entity that the command acted on. We should change it into something more meaningful, e.g. for catalog_validate
not the the path the command is run in, but the metadata file that is validated
The implementation of logging, exceptions, and datalad results rendering in this extension is inconsistent. This stems from my unfamiliarity with these concepts as I started developing. The code base could benefit a lot from an experienced datalad developer going through the code to identify places where the current implementation needs changes.
The modules where this would be most applicable are: