search

datalad / datalad-container

DataLad extension for containerized environments
http://datalad.org
Other
11 stars 17 forks source link

containers-add should throw error message when referenced image is outside of dataset #150

Open jkroell opened 3 years ago

jkroell commented 3 years ago

Running datalad containers-add fMRIprep -i '/data/project/singularity/fmriprep-20.2.0.simg' -d '/data/project/hcp_movies/hcp-openaccess/' did not result in an error even though data/project/singularity/fmriprep-20.2.0.simg does not exist in the dataset.

bpoldrack commented 3 years ago

Quick remark on that:

It's two issues with not checking the value of -i:

  1. It's supposed to be a relative path within the dataset and apparently we don't check that.
  2. I think -i makes no sense at all, when there's no source for the image given. We don't catch that either.