Closed mih closed 1 year ago
Code Climate has analyzed commit 3fc00796 and detected 0 issues on this pull request.
View more on Code Climate.
The failures are due to dockerhubs rate limiting:
toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
@adswa Yeah, the test setup is not so nice. Locally this works now -- also on windows.
any idea on how many tests would fail if windows is added as a test env?
any idea on how many tests would fail if windows is added as a test env?
When I execute the tests on windows (minus anything metalad-related https://github.com/datalad/datalad-metalad/issues/397 because I am working with PY3.12 right now), I see 8 failed, 13 passed.
A good chunk of the failures is simply https://github.com/datalad/datalad-container/issues/233, most of the rest is wrong path assumptions.
Rebased after merge of #235
All modified lines are covered by tests :white_check_mark:
Comparison is base (
4782a7a
) 94.59% compared to head (3fc0079
) 94.59%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Merging, given the approvals.
This placeholder is expanded on execution of a container, rather than on configuration/addition. This helps use the same Python installation that is also executing the datalad-container code.
Previously, the docker-support code would expand and then hardcode
sys.executable
on configuring a container. This led to non-portable configuration (e.g., hardcodedpython.exe
on windows), and would fail to pick up the correct python installation in any case where thepython
entrypoint would not point to the correct one.Closes #226 Almost does #224 (missing the platform path issue)