search

datalad / datalad-crawler

DataLad extension for tracking web resources as datasets
http://datalad.org
Other
5 stars 16 forks source link

RF: moved support/versions.py from datalad core #111

Closed yarikoptic closed 2 years ago

yarikoptic commented 2 years ago

used only in the crawler, and relies on distutils LooseVersion and distutils are getting deprecated. Relevant PR in datalad for distutils removal: https://github.com/datalad/datalad/pull/6113

codecov[bot] commented 2 years ago

Codecov Report

Merging #111 (77680f6) into master (6dacbf0) will increase coverage by 0.38%. The diff coverage is 98.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
+ Coverage   81.40%   81.79%   +0.38%     
==========================================
  Files          57       59       +2     
  Lines        4658     4768     +110     
==========================================
+ Hits         3792     3900     +108     
- Misses        866      868       +2
Impacted Files Coverage Δ
datalad_crawler/support/versions.py 97.22% <97.22%> (ø)
datalad_crawler/nodes/annex.py 81.05% <100.00%> (ø)
datalad_crawler/support/tests/test_versions.py 100.00% <100.00%> (ø)
datalad_crawler/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7313d47...77680f6. Read the comment docs.

yarikoptic commented 2 years ago

will need a release I guess to get datalad master with removed module CI green

yarikoptic commented 2 years ago

totally forgot that we do have auto releases for this one -- should have marked for the release :-/