datalad / datalad-crawler

DataLad extension for tracking web resources as datasets
http://datalad.org
Other
5 stars 16 forks source link

BF: nose is ATM run time requirement as well of crawler (see comment) #115

Closed yarikoptic closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #115 (faac2e1) into master (8e674f3) will increase coverage by 0.10%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
+ Coverage   81.79%   81.89%   +0.10%     
==========================================
  Files          59       59              
  Lines        4778     4778              
==========================================
+ Hits         3908     3913       +5     
+ Misses        870      865       -5     
Impacted Files Coverage Δ
datalad_crawler/version.py 100.00% <100.00%> (ø)
datalad_crawler/nodes/annex.py 81.14% <0.00%> (+0.14%) :arrow_up:
datalad_crawler/pipelines/tests/test_gh.py 63.63% <0.00%> (+18.18%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 61ff262...faac2e1. Read the comment docs.

yarikoptic commented 2 years ago

2 travis runs failed with

0.81s$ pip install -r requirements-devel.txt
Obtaining file:///home/travis/build/datalad/datalad-crawler (from -r requirements-devel.txt (line 1))
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [22 lines of output]
      Traceback (most recent call last):
        File "<string>", line 36, in <module>
        File "<pip-setuptools-caller>", line 14, in <module>
        File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/setuptools/__init__.py", line 18, in <module>
          from setuptools.dist import Distribution
        File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/setuptools/dist.py", line 34, in <module>
          from ._importlib import metadata
        File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/setuptools/_importlib.py", line 28, in <module>
          disable_importlib_metadata_finder(metadata)
        File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/setuptools/_importlib.py", line 12, in disable_importlib_metadata_finder
          import importlib_metadata
        File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/importlib_metadata/__init__.py", line 471, in <module>
          __version__ = version(__name__)
        File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/importlib_metadata/__init__.py", line 438, in version
          return distribution(package).version
        File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/importlib_metadata/__init__.py", line 411, in distribution
          return Distribution.from_name(package)
        File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/importlib_metadata/__init__.py", line 179, in from_name
          dists = resolver(name)
        File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/setuptools/_vendor/importlib_metadata/__init__.py", line 886, in find_distributions
          found = self._search_paths(context.name, context.path)
      AttributeError: 'str' object has no attribute 'name'
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

yet to figure out

yarikoptic commented 2 years ago

oh well -- it is something odd specifically with python 3.7. I do not see any python version specifics in our setup.py so I think the issue is "upstairs" somewhere and I will just close my eyes on this issue for now