datalad / datalad-crawler

DataLad extension for tracking web resources as datasets
http://datalad.org
Other
5 stars 16 forks source link

Switch to pytest #117

Closed jwodder closed 1 year ago

jwodder commented 2 years ago

Closes #116.

Note that this PR currently cannot be tested on CI, as there is no post-pytest release of datalad. (I tested the project locally by changing the datalad requirement in the tests extra to datalad @ git+https://github.com/datalad/datalad. Currently, three tests fail, all in datalad_crawler/nodes/tests/test_annex.py, all due to issues with paths in $TMPDIR that are likely to be macOS-specific.)

codecov[bot] commented 1 year ago

Codecov Report

Merging #117 (ce433ad) into master (e1f15fd) will decrease coverage by 4.21%. The diff coverage is 96.88%.

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
- Coverage   81.89%   77.68%   -4.22%     
==========================================
  Files          59       60       +1     
  Lines        4778     4710      -68     
  Branches        0      699     +699     
==========================================
- Hits         3913     3659     -254     
- Misses        865      887      +22     
- Partials        0      164     +164     
Impacted Files Coverage Δ
datalad_crawler/__init__.py 100.00% <ø> (ø)
datalad_crawler/pipelines/balsa.py 91.57% <ø> (-4.22%) :arrow_down:
datalad_crawler/pipelines/crcns.py 49.00% <ø> (-5.00%) :arrow_down:
datalad_crawler/pipelines/fcptable.py 54.90% <ø> (ø)
datalad_crawler/pipelines/openfmri.py 81.35% <ø> (-5.09%) :arrow_down:
datalad_crawler/pipelines/openfmri_s3.py 100.00% <ø> (ø)
datalad_crawler/pipelines/simple_with_archives.py 73.68% <ø> (-15.79%) :arrow_down:
datalad_crawler/tests/test_register.py 100.00% <ø> (ø)
datalad_crawler/pipelines/tests/test_crcns.py 64.00% <80.00%> (-8.00%) :arrow_down:
datalad_crawler/pipelines/tests/test_gh.py 60.86% <80.00%> (-2.77%) :arrow_down:
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8d0be73...ce433ad. Read the comment docs.

yarikoptic commented 1 year ago

hm, travis stopped reacting to my changes for some reason... I thought because of somehow breaking .travis.yml with dist: focal but seems to be not the case. will need to come back to this later :-/

yarikoptic commented 1 year ago

on this note of green Travis let's merge and release!