datalad / datalad-crawler

DataLad extension for tracking web resources as datasets
http://datalad.org
Other
5 stars 16 forks source link

DOC: Set language in Sphinx config to en #118

Closed adswa closed 1 year ago

adswa commented 2 years ago

Starting with Sphinx version 5.0, the configuration for the doc's language should not be None anymore and causes docbuild failures otherwise (see datalad/datalad#6715). This change sets the language specification to English (en)

codecov[bot] commented 2 years ago

Codecov Report

Merging #118 (0fca83b) into master (8e674f3) will increase coverage by 0.10%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
+ Coverage   81.79%   81.89%   +0.10%     
==========================================
  Files          59       59              
  Lines        4778     4778              
==========================================
+ Hits         3908     3913       +5     
+ Misses        870      865       -5     
Impacted Files Coverage Δ
datalad_crawler/version.py 100.00% <100.00%> (ø)
datalad_crawler/nodes/annex.py 81.14% <0.00%> (+0.14%) :arrow_up:
datalad_crawler/pipelines/tests/test_gh.py 63.63% <0.00%> (+18.18%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 61ff262...0fca83b. Read the comment docs.

mih commented 1 year ago

There was no update to this trivial PR in over a month. It is pretty much impossible that the diff could be anyhow responsible for the travis behavior (works on PY3.6 and 3.8, but not on 3.7). I restarted the failing CI jobs, but they came back with the same error.

In general, the CI setup seems stale. Pretty sure that git-annex v10 does not actually create repos in v5 mode.

yarikoptic commented 1 year ago

next time @mih @bpoldrack please just be brave and click a Merge button in such certain cases. No need to wait for blessing in our common project.