datalad / datalad-crawler

DataLad extension for tracking web resources as datasets
http://datalad.org
Other
5 stars 16 forks source link

Move definition of `HANDLE_META_DIR` into cralwer #125

Closed christian-monch closed 1 year ago

christian-monch commented 1 year ago

This commit moves the definition of HANDLE_META_DIR into the crawler. It is not used in any other extension and it will not present in datalad anymore after datalad PR #7014 is merged.

codecov[bot] commented 1 year ago

Codecov Report

Base: 77.64% // Head: 77.64% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (c5ef13d) compared to base (3ba80aa). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #125 +/- ## ======================================= Coverage 77.64% 77.64% ======================================= Files 60 60 Lines 4692 4693 +1 Branches 699 699 ======================================= + Hits 3643 3644 +1 Misses 885 885 Partials 164 164 ``` | [Impacted Files](https://codecov.io/gh/datalad/datalad-crawler/pull/125?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad) | Coverage Δ | | |---|---|---| | [datalad\_crawler/consts.py](https://codecov.io/gh/datalad/datalad-crawler/pull/125/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9jcmF3bGVyL2NvbnN0cy5weQ==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

yarikoptic commented 1 year ago

Great, thanks!