search

datalad / datalad-crawler

DataLad extension for tracking web resources as datasets
http://datalad.org
Other
5 stars 16 forks source link

Guard usage of the legacy method `meta_aggregate`, add datalad-deprecated into tests dependencies #126

Closed christian-monch closed 1 year ago

christian-monch commented 1 year ago

This PR guards the import and invocation of aggregate_metadata, and issues a warning to install either datalad_deprecated or datalad-metalad < 0.3.0.

This will become necessary to prevent uncaught exceptions after datalad PR #7014 /https://github.com/datalad/datalad/pull/7014) is merged.

codecov[bot] commented 1 year ago

Codecov Report

Base: 77.64% // Head: 77.54% // Decreases project coverage by -0.09% :warning:

Coverage data is based on head (55812fe) compared to base (9d55cb5). Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #126 +/- ## ========================================== - Coverage 77.64% 77.54% -0.10% ========================================== Files 60 60 Lines 4693 4699 +6 Branches 699 680 -19 ========================================== Hits 3644 3644 - Misses 885 890 +5 - Partials 164 165 +1 ``` | [Impacted Files](https://codecov.io/gh/datalad/datalad-crawler/pull/126?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad) | Coverage Δ | | |---|---|---| | [datalad\_crawler/pipelines/gh.py](https://codecov.io/gh/datalad/datalad-crawler/pull/126/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9jcmF3bGVyL3BpcGVsaW5lcy9naC5weQ==) | `0.00% <0.00%> (ø)` | | | [datalad\_crawler/nodes/annex.py](https://codecov.io/gh/datalad/datalad-crawler/pull/126/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9jcmF3bGVyL25vZGVzL2FubmV4LnB5) | `71.03% <40.00%> (-0.32%)` | :arrow_down: | | [datalad\_crawler/version.py](https://codecov.io/gh/datalad/datalad-crawler/pull/126/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9jcmF3bGVyL3ZlcnNpb24ucHk=) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

yarikoptic commented 1 year ago

sorry I missed this PR. I have added installation of datalad-deprecated into tests extra depends since we want to test with that functionality and also we would want a fresh run of CI here

bpoldrack commented 1 year ago

Restarted CI after deprecated release, @yarikoptic. I guess, merge and release if it passes or is there anything left to do from your POV?