datalad / datalad-crawler

DataLad extension for tracking web resources as datasets
http://datalad.org
Other
5 stars 16 forks source link

Fix metadata import and dependency on datalad-deprecated #129

Closed bpoldrack closed 1 year ago

bpoldrack commented 1 year ago

This was tested against a PR in core that removes the metadata related things from core and against a related bugfix PR in datalad-deprecated. Now switched back to regular testing against released dependencies.

codecov[bot] commented 1 year ago

Codecov Report

Base: 77.54% // Head: 77.54% // No change to project coverage :thumbsup:

Coverage data is based on head (69acbcf) compared to base (b733b06). Patch coverage: 66.66% of modified lines in pull request are covered.

:exclamation: Current head 69acbcf differs from pull request most recent head d654447. Consider uploading reports for the commit d654447 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #129 +/- ## ======================================= Coverage 77.54% 77.54% ======================================= Files 60 60 Lines 4699 4699 Branches 680 680 ======================================= Hits 3644 3644 Misses 890 890 Partials 165 165 ``` | [Impacted Files](https://codecov.io/gh/datalad/datalad-crawler/pull/129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad) | Coverage Δ | | |---|---|---| | [datalad\_crawler/pipelines/tests/test\_openfmri.py](https://codecov.io/gh/datalad/datalad-crawler/pull/129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9jcmF3bGVyL3BpcGVsaW5lcy90ZXN0cy90ZXN0X29wZW5mbXJpLnB5) | `89.02% <50.00%> (ø)` | | | [datalad\_crawler/version.py](https://codecov.io/gh/datalad/datalad-crawler/pull/129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad#diff-ZGF0YWxhZF9jcmF3bGVyL3ZlcnNpb24ucHk=) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datalad)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.