search

datalad / datalad-crawler

DataLad extension for tracking web resources as datasets
http://datalad.org
Other
5 stars 16 forks source link

BF: CRCNS - Skip (but warn if relevant) records without xml #32

Closed yarikoptic closed 5 years ago

yarikoptic commented 5 years ago

Haunts all recent PRs. Will merge asap (when tests pass)

yarikoptic commented 5 years ago

thanks @kyleam - need to wait for travis... for some reason is way too slow today

yarikoptic commented 5 years ago

Hm, I think the following failures are unrelated to proposed fix

datalad_crawler.pipelines.tests.test_simple_with_archives.test_crawl_autoaddtext(True,) ... 
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

so I would be inclined to merge and then figure them out separately

yarikoptic commented 5 years ago

Yeap, the same on master https://travis-ci.org/datalad/datalad-crawler/jobs/476911070 so merging