RF: strip "enforced" direct mode in the tests

datalad / datalad-crawler

DataLad extension for tracking web resources as datasets

http://datalad.org

Other

5 stars 16 forks source link

RF: strip "enforced" direct mode in the tests #36

Closed yarikoptic closed 5 years ago

yarikoptic commented 5 years ago

It would still run via setting environment variable, so whenever core doesn't support direct mode, it just would be a regular mode and thus crawler could stay compatible with both 0.11 and 0.12 lines

kyleam commented 5 years ago

I don't think any of those failures are related to this PR. It looks like the autoaddtext issue has resurfaced.

yarikoptic commented 5 years ago

I don't think any of those failures are related to this PR. It looks like the autoaddtext issue has resurfaced.

That is what you (well - I) get it when postponing fixing the problem. I "resolved" it by stopping to test against master which introduced that handling of .gz files at that point, and now it is released, so problem has resurfaced indeed. Thanks for looking it up!

yarikoptic commented 5 years ago

Since we aren't breaking it more than it is already, let's merge